search

biocore / American-Gut

American Gut open-access data and IPython notebooks
Other
107 stars 81 forks source link

Adding in setup.py #171

Closed mortonjt closed 8 years ago

wasade commented 8 years ago

Few comments, :+1: otherwise once tests pass

mortonjt commented 8 years ago

:boom: tests passing

squirrelo commented 8 years ago

Already merged now, but did we really need a setup.py given that this is primarily a collection of notebooks and data? Would a pip requirements.txt and/or the conda equivalent have been more appropriate?

wasade commented 8 years ago

It makes deployment easier

On Sat, Oct 24, 2015 at 8:54 PM, Joshua Shorenstein < notifications@github.com> wrote:

Already merged now, but did we really need a setup.py given that this is primarily a collection of notebooks and data? Would a pip requirements.txt and/or the conda equivalent have been more appropriate?

— Reply to this email directly or view it on GitHub https://github.com/biocore/American-Gut/pull/171#issuecomment-150886989.

squirrelo commented 8 years ago

eh, 

pip install .

vs 

pip install -r requirements.txt
echo $(pwd)/scripts >  .bash_profile

The second has an extra line, but also doesn't treat the repo as a full installable package. I guess the question for me is, should this be treated as a full installable package or a collection of notebooks?

wasade commented 8 years ago

What's the downside to it being installable?

On Sat, Oct 24, 2015 at 9:46 PM, Joshua Shorenstein < notifications@github.com> wrote:

eh,

pip install .

vs

pip install -r requirements.txtecho $(pwd)/scripts > .bash_profile

The second has an extra line, but also doesn't treat the repo as a full installable package. I guess the question for me is, should this be treated as a full installable package or a collection of notebooks?

— Reply to this email directly or view it on GitHub https://github.com/biocore/American-Gut/pull/171#issuecomment-150889681.