search

biocore / American-Gut

American Gut open-access data and IPython notebooks
Other
107 stars 81 forks source link

blanks are special again #175

Closed wasade closed 8 years ago

wasade commented 8 years ago

Yet another way to describe body sites for blanks

wasade commented 8 years ago

@squirrelo @EmbrietteH, is this case still necessary to handle?

squirrelo commented 8 years ago

Still investigating.

wasade commented 8 years ago

The changes just pushed in were necessary to resolve issues encountered with the production data.

wasade commented 8 years ago

Assuming tests pass, would it be possible for a rapid review on this?

cc @squirrelo @EmbrietteH @ElDeveloper @josenavas @antgonza

wasade commented 8 years ago

Tests should be passing, possible for review please?

ElDeveloper commented 8 years ago

No, stop asking ... jk, I'm on it.

On (Nov-06-15|12:20), Daniel McDonald wrote:

Tests should be passing, possible for review please?

Reply to this email directly or view it on GitHub: https://github.com/biocore/American-Gut/pull/175#issuecomment-154521588

ElDeveloper commented 8 years ago

Looks good to me, just a copule of comments, nothing blocking. Should be ready to go granted that tests pass.

mortonjt commented 8 years ago

:+1: