test_generate_otu_significance.py fails

[ElDeveloper]

python test_generate_otu_signifigance.py

.F.......
======================================================================
FAIL: test_calculate_tax_rank_1 (__main__.GenerateOTUSignifiganceTablesTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_generate_otu_signifigance.py", line 245, in test_calculate_tax_rank_1
    self.assertEqual(known_high_10, test_high_10)
AssertionError: Lists differ: [['k__Bacteria; p__Proteobacte... != [['k__Bacteria; p__Proteobacte...

First differing element 0:
['k__Bacteria; p__Proteobacteria; c__Gammaproteobacteria; o__Enterobacteriales; f__Enterbacteriaceae', 0.002, 7.6e-05, 26.3158, 1.450729834568669e-22]
['k__Bacteria; p__Proteobacteria; c__Gammaproteobacteria; o__Enterobacteriales; f__Enterbacteriaceae', 0.002, 7.6e-05, 26.0, 1.4507298345686689e-22]

Diff is 671 characters long. Set self.maxDiff to None to see it.

---

@JWDebelius can you look into this?

[wasade]

This is from the rounding fix. Fold change was being rounded to 4 signficant digits and then truncated when written out (i.e., "%d"). The fix was to round to whole numbers. For got to fix test code, can do this possibly this afternoon if necessary

On Tue, Nov 12, 2013 at 9:07 PM, Yoshiki Vázquez Baeza < notifications@github.com> wrote:

python test_generate_otu_signifigance.py

.F.......======================================================================FAIL: test_calculate_tax_rank_1 (main.GenerateOTUSignifiganceTablesTest)----------------------------------------------------------------------Traceback (most recent call last): File "test_generate_otu_signifigance.py", line 245, in test_calculate_tax_rank_1 self.assertEqual(known_high_10, test_high_10)AssertionError: Lists differ: [['kBacteria; pProteobacte... != [['kBacteria; pProteobacte... First differing element 0:['kBacteria; pProteobacteria; cGammaproteobacteria; oEnterobacteriales; fEnterbacteriaceae', 0.002, 7.6e-05, 26.3158, 1.450729834568669e-22]['kBacteria; pProteobacteria; cGammaproteobacteria; oEnterobacteriales; fEnterbacteriaceae', 0.002, 7.6e-05, 26.0, 1.4507298345686689e-22] Diff is 671 characters long. Set self.maxDiff to None to see it.

---

@JWDebelius https://github.com/JWDebelius can you look into this?

— Reply to this email directly or view it on GitHubhttps://github.com/qiime/American-Gut/issues/39 .

[jwdebelius]

I fixed tests for rounding and will open a pull request.

[ElDeveloper]

Thanks!

On Nov 13, 2013, at 11:15 AM, J W Debelius notifications@github.com wrote:

I fixed tests for rounding and will open a pull request.

— Reply to this email directly or view it on GitHub.

[wasade]

can this be closed?

[ElDeveloper]

Closed or Merged?

[ElDeveloper]

Oh pfft my bad.