Adding OTU signifigance and Phyla plots

biocore / American-Gut

American Gut open-access data and IPython notebooks

Other

108 stars 81 forks source link

Adding OTU signifigance and Phyla plots #6

Closed jwdebelius closed 10 years ago

jwdebelius commented 10 years ago

Test code to follow.

ElDeveloper commented 10 years ago

Just FYI, you submitted this pull request from your master branch, what you usually want to do is to submit them from a feature branch. The step that you missed is running git checkout -b something where something is the name of the branch where these changes would take place.

ElDeveloper commented 10 years ago

I've added some inline comments and have the next few suggestions:

Move all the functions contained in the scripts to their own module under the americangut folder.
Add tests for each of these newly created modules.
Remove all commented out code that will not ultimately be useful.
There's no need to have AGP at the end of the script names as this is inherently code for the AGP.
chmod +x generate_otu_signifigance_tables_AGP.py make_phyla_plots_AGP.py to make your scripts executable.

jwdebelius commented 10 years ago

I think I did this in the wrong branch again this time

ElDeveloper commented 10 years ago

:) there's no correct branch really; there are conventions but there's not a "correct" one though.

On Oct 25, 2013, at 4:24 PM, J W Debelius notifications@github.com wrote:

I think I did this in the wrong branch again this time

— Reply to this email directly or view it on GitHub.