search

biocore / American-Gut

American Gut open-access data and IPython notebooks
Other
113 stars 81 forks source link

Regex simplification #8

Closed ElDeveloper closed 11 years ago

ElDeveloper commented 11 years ago

After talking with @adamrp he figured that the regex could be simplified (which we did). Additionally I added a small check for stdout and stderr for the inkscape subprocess call; oddly enough the return code can be equal to zero but the program will not execute the conversion successfully.

ElDeveloper commented 11 years ago

@adamrp @wasade any chance you guys could review this PR and let me know if there are changes that need to take place?

wasade commented 11 years ago

on it

On Wed, Oct 30, 2013 at 4:39 PM, Yoshiki Vázquez Baeza < notifications@github.com> wrote:

@adamrp https://github.com/adamrp @wasade https://github.com/wasadeany chance you guys could review this PR and let me know if there are changes that need to take place?

— Reply to this email directly or view it on GitHubhttps://github.com/qiime/American-Gut/pull/8#issuecomment-27446068 .

ElDeveloper commented 11 years ago

Thanks bromigo!

On Oct 30, 2013, at 4:43 PM, Daniel McDonald notifications@github.com wrote:

Merged #8.

— Reply to this email directly or view it on GitHub.