biocore / LabControl

lab manager for plate maps and sequence flows
BSD 3-Clause "New" or "Revised" License
2 stars 15 forks source link

Note re: Slickgrid version #563

Open fedarko opened 5 years ago

fedarko commented 5 years ago

While talking with @charles-cowart I realized that I wasn't actually sure which version of SlickGrid was in use (since the "main" SlickGrid repo stopped development almost 3.5 years ago).

After examining our slick.grid.js file, as well as this comment from Amanda, I'm pretty sure we're using the 6pac community fork (which is still actively maintained).

@charles-cowart suggested I make this issue in order to:

  1. just make note of this somewhere, because otherwise the next batch of LabControl developers will have to look this up
  2. make a note for the future about updating SlickGrid to the newest available version (it looks like the 6pac fork is on v2.4 and we're on v2.3, so if desired we can update to that as a part of this sprint).
fedarko commented 5 years ago

More notes for the future:

fedarko commented 5 years ago

Another note:

From what I can tell, we currently use an additional grid to simulate a "frozen column" (i.e. keeping the first column in place even when the plate is scrolled horizontally). This is documented in this comment.

It looks like (as of December 2018) SlickGrid officially supports frozen columns, so we could theoretically do away with this hack if we upgrade our SlickGrid version.

charles-cowart commented 5 years ago

I'd like to do away with the additional grid eventually; I will flag this for post full-release TODOs.