Closed wasade closed 9 years ago
The code looks fine but as you said, you are missing tests for parse_m9, update licenses & tutorial, and you have flake8 errors. However, really close.
Also update setup.py to remove cogent, update the license in setup.py, and update the headers in the files to change GPL -> BSD (woot!!)
On (Apr-21-15|20:53), Antonio Gonzalez wrote:
The code looks fine but as you said, you are missing tests for parse_m9, update licenses & tutorial, and you have flake8 errors. However, really close.
Reply to this email directly or view it on GitHub: https://github.com/biocore/Platypus-Conquistador/pull/30#issuecomment-95020153
@antgonza @ElDeveloper, just need to do the sortmerna test. ran out of time this morning before needing to head out, should only take another 15 though so assuming wifi works on my laptop, i'll have it in before noon
Thanks for the update.
@antgonza @ElDeveloper, okay, should be good for review.
Thanks for updating this! Would you mind also updating INSTALL.md to remove pycogent from that list?
I think the comments are addressed.
can you add a test that raises the valueerror due to having more than 12 fields in an input file?
ValueError
is now specific
:+1:
DO NOT MERGEMissing tests, need to update licenses.Good for review and merge.