search

biocore / Platypus-Conquistador

Confirming specific taxonomic groups within your samples.
Other
19 stars 5 forks source link

ENH/BLD: no cogent dependency, support for sortmerna #30

Closed wasade closed 9 years ago

wasade commented 9 years ago

DO NOT MERGE

Missing tests, need to update licenses.

Good for review and merge.

antgonza commented 9 years ago

The code looks fine but as you said, you are missing tests for parse_m9, update licenses & tutorial, and you have flake8 errors. However, really close.

ElDeveloper commented 9 years ago

Also update setup.py to remove cogent, update the license in setup.py, and update the headers in the files to change GPL -> BSD (woot!!)

On (Apr-21-15|20:53), Antonio Gonzalez wrote:

The code looks fine but as you said, you are missing tests for parse_m9, update licenses & tutorial, and you have flake8 errors. However, really close.

Reply to this email directly or view it on GitHub: https://github.com/biocore/Platypus-Conquistador/pull/30#issuecomment-95020153

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.69%) to 96.43% when pulling 5cdb5c27c60245b2ea3398254bbb58573edf3fdd on wasade:to_bsd into 5b5077f61d851f91030ce1726f40e50bd7db0a92 on biocore:master.

wasade commented 9 years ago

@antgonza @ElDeveloper, just need to do the sortmerna test. ran out of time this morning before needing to head out, should only take another 15 though so assuming wifi works on my laptop, i'll have it in before noon

antgonza commented 9 years ago

Thanks for the update.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.7%) to 97.42% when pulling 495881d4c9a70fc76eca48477098d44739ef3321 on wasade:to_bsd into 5b5077f61d851f91030ce1726f40e50bd7db0a92 on biocore:master.

wasade commented 9 years ago

@antgonza @ElDeveloper, okay, should be good for review.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.68%) to 97.45% when pulling 92f9942310c55d02e5f8cfe1b9cad5485f53b4eb on wasade:to_bsd into 5b5077f61d851f91030ce1726f40e50bd7db0a92 on biocore:master.

ElDeveloper commented 9 years ago

Thanks for updating this! Would you mind also updating INSTALL.md to remove pycogent from that list?

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.27%) to 97.85% when pulling 89378489ba69da2650ad919745d90351e0e69e55 on wasade:to_bsd into 5b5077f61d851f91030ce1726f40e50bd7db0a92 on biocore:master.

wasade commented 9 years ago

I think the comments are addressed.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.16%) to 98.28% when pulling 89378489ba69da2650ad919745d90351e0e69e55 on wasade:to_bsd into 5b5077f61d851f91030ce1726f40e50bd7db0a92 on biocore:master.

antgonza commented 9 years ago

can you add a test that raises the valueerror due to having more than 12 fields in an input file?

wasade commented 9 years ago

ValueError is now specific

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.16%) to 98.28% when pulling e9eedd2755ddc9ea218a871ddb3faa0b4d8c040c on wasade:to_bsd into 5b5077f61d851f91030ce1726f40e50bd7db0a92 on biocore:master.

ElDeveloper commented 9 years ago

:+1: