biocore / american-gut-web

The website for the American Gut Project participant portal
BSD 3-Clause "New" or "Revised" License
5 stars 24 forks source link

New surveys #591

Closed squirrelo closed 8 years ago

squirrelo commented 8 years ago

This adds the fermented foods and surfing surveys into the possible secondary surveys for humans.

This also adds the ability to log multiple surveys to the same existing consent.

Requires #590

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.09%) to 60.448% when pulling 9dbc3cb6d67c258ce98581ffd3468c574eb2f7b4 on squirrelo:new-surveys into bbfbf6863a761ff997f91c7716d5f4435b659a02 on biocore:master.

squirrelo commented 8 years ago

Coverage went down, hence the X, but tests all pass. Ready for review.

EmbrietteH commented 8 years ago

Why is coverage going down? It should always go up-and we shouldn't make a habit of letting it slide.

squirrelo commented 8 years ago

Things like adding to the translation dicts can cause it to go down, since they are technically .py files and have no tests.

squirrelo commented 8 years ago

Also has to do with none of the handlers having tests.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.4%) to 61.145% when pulling 65428cc4ed0a9b9a46841a7aa12852b70def26a3 on squirrelo:new-surveys into bbfbf6863a761ff997f91c7716d5f4435b659a02 on biocore:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.02%) to 61.52% when pulling 3ca3b1308f2ec5d191b693bbd9ad5468510f1993 on squirrelo:new-surveys into bbfbf6863a761ff997f91c7716d5f4435b659a02 on biocore:master.

EmbrietteH commented 8 years ago

A few comments, @ackermag please also check.

ackermag commented 8 years ago

I think this looks fine

On Wed, Jun 8, 2016 at 9:57 AM, Embriette Hyde notifications@github.com wrote:

A few comments, @ackermag https://github.com/ackermag please also check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/american-gut-web/pull/591#issuecomment-224656696, or mute the thread https://github.com/notifications/unsubscribe/AB69gLh5wfkfEdWibWBnFGzZQG4Hke25ks5qJvRqgaJpZM4Iq_1H .

Gail Ackermann Knight Lab UCSD glackermann@ucsd.edu ackermag@ucsd.edu

josenavas commented 8 years ago

Some comments

squirrelo commented 8 years ago

Comments addressed

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.06%) to 62.6% when pulling c36d3d399672a7d58536c683f05298a31921b2f5 on squirrelo:new-surveys into bbfbf6863a761ff997f91c7716d5f4435b659a02 on biocore:master.

josenavas commented 8 years ago

@squirrelo #590 has been merged - can you pull from upstream?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.06%) to 62.6% when pulling e39336f853416192c99208ac84f8e24e3df54b0a on squirrelo:new-surveys into cb6894fdf9ebd30f38581f606e60965e5bbf4772 on biocore:master.

squirrelo commented 8 years ago

Done