Closed squirrelo closed 8 years ago
Coverage went down, hence the X, but tests all pass. Ready for review.
Why is coverage going down? It should always go up-and we shouldn't make a habit of letting it slide.
Things like adding to the translation dicts can cause it to go down, since they are technically .py files and have no tests.
Also has to do with none of the handlers having tests.
A few comments, @ackermag please also check.
I think this looks fine
On Wed, Jun 8, 2016 at 9:57 AM, Embriette Hyde notifications@github.com wrote:
A few comments, @ackermag https://github.com/ackermag please also check.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/american-gut-web/pull/591#issuecomment-224656696, or mute the thread https://github.com/notifications/unsubscribe/AB69gLh5wfkfEdWibWBnFGzZQG4Hke25ks5qJvRqgaJpZM4Iq_1H .
Gail Ackermann Knight Lab UCSD glackermann@ucsd.edu ackermag@ucsd.edu
Some comments
Comments addressed
@squirrelo #590 has been merged - can you pull from upstream?
Done
This adds the fermented foods and surfing surveys into the possible secondary surveys for humans.
This also adds the ability to log multiple surveys to the same existing consent.
Requires #590