search

biocore / american-gut-web

The website for the American Gut Project participant portal
BSD 3-Clause "New" or "Revised" License
5 stars 24 forks source link

Delete sample bug #622

Closed antgonza closed 7 years ago

antgonza commented 7 years ago

This should pass all tests.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.02%) to 63.741% when pulling 8964312cf2205dee5dca1abc18d84895acd107fb on antgonza:delete_sample_bug into 888095168b6bf8b6b1991dbac6330a380f9a4a29 on biocore:master.

wasade commented 7 years ago

I'm :+1: but I'm biased :)

@josenavas @mortonjt @ElDeveloper possible for review? PR is short, and addresses a bug in production.

cc @EmbrietteH

mortonjt commented 7 years ago

At a first glance, this looks ok.

But I guess I'm a little confused about what is going on. It seems like the function signature for deleteSamples was initially accepting an ag_login_id. Was the deleteAGParticipantSurvey always broken? If so, 👍 for resolving this.

wasade commented 7 years ago

yes

On Tue, Sep 27, 2016 at 7:21 PM, Jamie Morton notifications@github.com wrote:

At a first glance, this looks ok.

But I guess I'm a little confused about what is going on. It seems like the function signature for deleteSamples was initially accepting an ag_login_id. Was the deleteAGParticipantSurvey always broken? If so, 👍 for resolving this.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/biocore/american-gut-web/pull/622#issuecomment-250054816, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc8shNQp_Tz6-9V1IHq7kQr0Gfr7GZbks5quc80gaJpZM4KHxjM .

mortonjt commented 7 years ago

Ok. Then if there is no objections, I can merge this.

wasade commented 7 years ago

that'd be great, thanks!!

mortonjt commented 7 years ago

Thanks @antgonza !