search

biocore / american-gut-web

The website for the American Gut Project participant portal
BSD 3-Clause "New" or "Revised" License
5 stars 24 forks source link

Bugfix surveyoverview #632

Closed sjanssen2 closed 7 years ago

sjanssen2 commented 7 years ago

Fix for: An error message is popping up when participants try to access the participant profile for their animal samples. We have tried on the test account as well and find the same error when hovering over Animal Samples --> clicking animal participant profile. Just wanted to give you a heads up!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 63.54% when pulling 2cdc8c0a474f8656ffab9c0d1adc863ad2cf498c on sjanssen2:bugfix_surveyoverview into d4b9f0606ea8f54516f7c8cdaf6fd191fea442ed on biocore:master.

sjanssen2 commented 7 years ago

@EmbrietteH @josenavas @wasade please review this PR which addresses the bug with the rendering of animal samples.

Problem was that all old animals where also present with the same participant name as humans (which doesn't make sense). Only lately added animals did not have human versions. Since rendering relied on human information, it failed for those newer animals.

sjanssen2 commented 7 years ago

I cannot add useful unit tests, since we don't have a DB with animal or secondary surveys. Thus, coverage decreases.

wasade commented 7 years ago

only had 1 minor comment

sjanssen2 commented 7 years ago

ready to merge @wasade ?

EmbrietteH commented 7 years ago

ping @josenavas ping @mortonjt

sjanssen2 commented 7 years ago

Thanks guys!