search

biocore / american-gut-web

The website for the American Gut Project participant portal
BSD 3-Clause "New" or "Revised" License
5 stars 24 forks source link

fixed false assumption that a participant (source) has only one surve… #637

Closed sjanssen2 closed 7 years ago

sjanssen2 commented 7 years ago

…y_id, when deleting this participant. See issue #636

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 63.707% when pulling 2974e150847cb645074e5840ef7f05e56c9434c7 on sjanssen2:bugfix_deleteSource into f7f42ead47f27e2d7c4a51358d33b78d123a39f8 on biocore:master.

sjanssen2 commented 7 years ago

@EmbrietteH @wasade @josenavas please have a look at this PR which should fix the issue #636

sjanssen2 commented 7 years ago

Please think about fact that a participant might have multiple email addresses. If so, do we want to list them only once in the ag.consent_revoked table or multiple times each with a different email?

Currently, the later is implemented.

sjanssen2 commented 7 years ago

test are not possible, because there is no (survey_login_id, participant_name) tuple that appears more than once :-(

wasade commented 7 years ago

:+1: following @josenavas's comments

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 63.641% when pulling d6c820f3a9cd92d0ddc3d055cb3bed5c049389c8 on sjanssen2:bugfix_deleteSource into f7f42ead47f27e2d7c4a51358d33b78d123a39f8 on biocore:master.

qiyunzhu commented 7 years ago

I sat with @sjanssen2 and read the PR. It looks all good to the best of my knowledge.