search

biocore / american-gut-web

The website for the American Gut Project participant portal
BSD 3-Clause "New" or "Revised" License
5 stars 24 forks source link

Remove incorrect vioscreen responses #682

Closed wasade closed 7 years ago

wasade commented 7 years ago

The labadmin data access method store_external_survey stored incorrect results due to an invalid split on , without respect to quoted values. All previously stored vioscreen entries are invalid.

EmbrietteH commented 7 years ago

@josenavas @sjanssen2 can I get a review?

sjanssen2 commented 7 years ago

If it is a off-by-one shift in the question / answer assocations., shouldn't we be able to correct those associations? However, considering the migration to Viocare's API interfacing, it will save a lot of time if we don't have to check if existing data are consistent with new to be pulled down ones. Therefore, I vote for deleting whatever is in our DB!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 64.345% when pulling 6c3d405ae01051114e1992fb94ff953b36e3b1da on wasade:remove_vioscreen_responses into 6c645603bb5c0b481cfb176b22e7ea8c131bdf21 on biocore:master.

wasade commented 7 years ago

The shift is lossy, and it's possible there is a > 1 shift