search

biocore / american-gut-web

The website for the American Gut Project participant portal
BSD 3-Clause "New" or "Revised" License
5 stars 24 forks source link

Open bill of rights links in new tab/window #720

Closed fedarko closed 5 years ago

fedarko commented 5 years ago

When the bill of rights PDF opens in the same tab/window, the user has to navigate "back" to return to the new participant page. However, when the user returns to the page, the containers of the consent/assent forms are kept closed and the radio button for age selection is kept selected -- which means the user has to manually select another age and then select the correct age option in order to re-open the correct consent/assent forms.

This is a partial fix for this problem, since it should make the bill of rights PDF open in a new tab or window (preserving the context of the original page). However, I think it'd also be a good idea to fix the problem of the consent/assent containers automatically closing in the future, in case the user ends up navigating back to this page anyway (due to either clicking a link in the sidebar, or their browser not recognizing target="_blank" for the bill of rights PDF).

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 70.195% when pulling c06d3931638860b10c4f26492fbb6325b72d6dbd on fedarko:master into 8a7d62e32e9c8eeffa1201e632da252ee6306b68 on biocore:master.

wasade commented 5 years ago

Awesome, thank you!