search

biocore / biom-format

The Biological Observation Matrix (BIOM) Format Project
http://biom-format.org
Other
89 stars 95 forks source link

Disallow head to have values <= 0 #919

Closed wasade closed 1 year ago

wasade commented 1 year ago

Fixes #899

@peterjc, I'm not allowing values of 0 here as obtaining sample or observation IDs can be performed with biom table-ids

peterjc commented 1 year ago

Perhaps special case 0 with a recommendation to use biom table-ids, with negative numbers giving the error as written?

wasade commented 1 year ago

Added, thanks!

peterjc commented 1 year ago

Looks good to me :)