search

biocore / biom-format

The Biological Observation Matrix (BIOM) Format Project
http://biom-format.org
Other
89 stars 95 forks source link

Issue 896 #920

Closed wasade closed 1 year ago

wasade commented 1 year ago

Remove h5py optional considerations

Fixes #896

peterjc commented 1 year ago

Minor comment: I'd put the import h5py line before your local imports. I can recommend tools to do this sorting automatically.

Flake8 still failing with several F401 'pytest' imported but unused

peterjc commented 1 year ago

Looks like where you've removed the @pytest.mark.skipif decorators, some of those files now have a redundant import pytest which is why flake8 complains.

wasade commented 1 year ago

Missing flake8 is what I get for pushing in changes at the end of the day... but it's also a perpetual reminder of the benefit of switching to black.

peterjc commented 1 year ago

I know what you mean. Note black wouldn't have caught this though.

Personally I now use the tool pre-commit framework to run flake8 and black as a git pre-commit hook (and as part of CI testing), https://pre-commit.com/

wasade commented 1 year ago

That's a great find, thank you!