update_ids strict=False is not necessarily working as expected

biocore / biom-format

The Biological Observation Matrix (BIOM) Format Project

http://biom-format.org

Other

89 stars 95 forks source link

update_ids strict=False is not necessarily working as expected #943

Closed wasade closed 3 months ago

wasade commented 7 months ago

update_ids(..., strict=False) appears to detect duplicate IDs. The issue is not isolated, and a minimal example with the example_table did not work on a first attempt.

wasade commented 3 months ago

I believe this was related to #957 as strict=False could truncate IDs artificially creating duplicates.