search

biocore / biom-format

The Biological Observation Matrix (BIOM) Format Project
http://biom-format.org
Other
89 stars 95 forks source link

Issue 952 #961

Closed wasade closed 3 months ago

wasade commented 3 months ago

Fixes #952 Fixes https://github.com/qiime2/q2-feature-table/issues/245

@mortonjt, are you able to review?

mortonjt commented 3 months ago

Hi, I think this fix is good enough. We just need to keep a mental note that np.ceil is applied to the data before subsampling to ensure that all low-abundance datasets have a chance to be sampled. But given that this is a nuanced technical detail, I'm OK with merging as is.

wasade commented 3 months ago

Wonderful, thank you! And good point -- I'll add a mention in the docstring.

wasade commented 3 months ago

@mortonjt, please let me know if there are concerns with that text otherwise I'll merge

mortonjt commented 3 months ago

LGTM