search

biocore / calour

exploratory and interactive microbiome analyses based on heatmaps
BSD 3-Clause "New" or "Revised" License
27 stars 22 forks source link

remove normaliztion check warning from filter_by_data() #276

Closed amnona closed 2 years ago

amnona commented 2 years ago

To prevent the warning when reading an experiment

amnona commented 2 years ago

@RNAer can you merge?

RNAer commented 2 years ago

why removing this? a friendly warning doesn't hurt

amnona commented 2 years ago

Since we filter (for min_reads) prior to normalization, you get this warning every time you load an experiment (for example using read_amplicon). It is confusing to the user. In general, sometimes you want to filter by data even without normalization (for example when looking at metabolomics, which is absolute abundance and therefore no need to normalize), so this warning is not needed. Also, since you must specify the normalization, the user is aware of the fact if his data is normalized or not

amnona commented 2 years ago

resolved conflict again :)