biocore / deblur

Deblur is a greedy deconvolution algorithm based on known read error profiles.
BSD 3-Clause "New" or "Revised" License
92 stars 41 forks source link

replace e-value with bit-score filtering #146

Closed amnona closed 7 years ago

amnona commented 7 years ago

for reference/non-reference hits

wasade commented 7 years ago

Thanks! Will pull down in a second

On Mar 16, 2017 4:52 PM, "amnona" notifications@github.com wrote:

for reference/non-reference hits

You can view, comment on, or merge this pull request online at:

https://github.com/biocore/deblur/pull/146 Commit Summary

  • replace e-value with bit-score filtering for reference/non-reference hits

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/biocore/deblur/pull/146, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc8st-3y3sXIUAO-UxKsP62lhAVgpA6ks5rmcs_gaJpZM4MgBUS .

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 3aea616191d17b522eb12081dc05a880a89a011c on bitscore into on master.

wasade commented 7 years ago

Further note, this is additional analysis of the sortmerna benchmarking (see here).

wasade commented 7 years ago

@amnona, small note, can you please bump __init__.__version__ to 1.0.1-dev0 please? That should have been done already but slipped through on the release.

mortonjt commented 7 years ago

👍

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 4c182a6976ab1841a02834982a01e8616f54c3bf on bitscore into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 111391a3dec7533e77011bd482e788ad37777371 on bitscore into on master.

wasade commented 7 years ago

Thanks!

On Mar 17, 2017 15:13, "Coveralls" notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/10654755

Changes Unknown when pulling 111391a https://github.com/biocore/deblur/commit/111391a3dec7533e77011bd482e788ad37777371 on bitscore into on master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/biocore/deblur/pull/146#issuecomment-287484418, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc8siT_SFnPoSGddVRR--Pa0Lk6oOHYks5rmwWKgaJpZM4MgBUS .