search

biocore / deblur

Deblur is a greedy deconvolution algorithm based on known read error profiles.
BSD 3-Clause "New" or "Revised" License
92 stars 41 forks source link

BUGFIX: 1E9 as float, and fixing the unit tests #177

Closed amnona closed 6 years ago

amnona commented 6 years ago

BUGFIX in recent python versions, 1E9 (which is used as the number of rows in the sparse matrix converted to biom) is treated as float rather than int, causing the allocation to fail Also, unit testing expects in the output fasta to have "size=XXX;" whereas deblur now gives "size=XXX" (without the trailing ";"). Fixed the unit test.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 88.672% when pulling 628a3de45b1f00df9eb65b00fba3e847a8b3201d on fixfloat into 2f66636dd6c928c0dc192f1c390b0246851775dd on master.

amnona commented 6 years ago

fixed the changelog :) ready for merge

amnona commented 6 years ago

fixed version to 1.0.4-dev and corresponding changelog