Fix a problem where invisible or transparent objects would be intersected

biocore / emperor

Emperor a tool for the analysis and visualization of large microbial ecology datasets

http://biocore.github.io/emperor/

Other

52 stars 50 forks source link

Fix a problem where invisible or transparent objects would be intersected #728

Closed ElDeveloper closed 4 years ago

ElDeveloper commented 5 years ago

This PR explicitly removes objects that are not visible when raycasting.

ElDeveloper commented 4 years ago

Code looks good, just wondering if it this new code news new tests ...

Just went through the tests for ScenePlotView and it doesn't look like we were ever able to test point intersections before. I vaguely remember this being related to the fact we use an SVG renderer for testing. For this specific case we need to render shaders which the SVG renderer isn't even capable of handling at the moment. So this PR should be good to go as is.

🙏

ElDeveloper commented 4 years ago

Thanks @antgonza!

On (Oct-22-19|11:12), Antonio Gonzalez wrote:

Merged #728 into new-api.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/biocore/emperor/pull/728#event-2734303855