search

biocore / emperor

Emperor a tool for the analysis and visualization of large microbial ecology datasets
http://biocore.github.io/emperor/
Other
52 stars 50 forks source link

Enabling filtering of missing features #731

Closed mortonjt closed 4 years ago

mortonjt commented 5 years ago

Addresses #730

Now when the ignore_missing_samples flag is enabled, features can also be enabled.

This is an easy fix - but maybe the terminology will need to be readdressed (i.e. change ignore_missing_samples -> ignore_missing).

mortonjt commented 5 years ago

@ElDeveloper , is there any chance that this can get merged in? This is becoming a bottleneck when mass producing emperor plots.

mortonjt commented 5 years ago

@ElDeveloper , I think you are right - this block needs more investigation. Just ran into another issue when I use the patch that I proposed. See #733

Regarding more informative errors, maybe we could just use the index name? That way no new parameters have to be passed in

ElDeveloper commented 4 years ago

I've opened a new PR based on these changes, see #734. . It fixes #730 and #733.