search

biocore / emperor

Emperor a tool for the analysis and visualization of large microbial ecology datasets
http://biocore.github.io/emperor/
Other
52 stars 50 forks source link

Fixes issue with slickgrid re-rendering #746

Closed ElDeveloper closed 4 years ago

ElDeveloper commented 4 years ago

This fixes an issue of category values not updating after a new metadata column is selected. The issue was a missing call to invalidate and render in the grid.

The animated GIF bellow shows the interface working again:

issue-744

antgonza commented 4 years ago

Looks good, worth adding a test?

ElDeveloper commented 4 years ago

Any ideas on how to test this? The data model is updated, it is only the view that doesn't get updated unless you force a refresh/render call.

On (Dec-13-19|10:33), Antonio Gonzalez wrote:

Looks good, worth adding a test?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/biocore/emperor/pull/746#issuecomment-565556091

antgonza commented 4 years ago

Not sure if possible but perhaps checking the container and see that the new elements/values are in there? If not possible then is fine ...

ElDeveloper commented 4 years ago

@antgonza, I just pushed some changes that add some tests. Albeit these are rather limited, I use jquery to see if we can find elements with the expected categories.