search

biocore / emperor

Emperor a tool for the analysis and visualization of large microbial ecology datasets
http://biocore.github.io/emperor/
Other
52 stars 50 forks source link

Duplicate axis created when using weird axis settings #748

Closed fedarko closed 4 years ago

fedarko commented 4 years ago

This seems to me like a pretty obscure problem, but I think it is technically a bug.

Steps to reproduce

  1. Open up a plot or biplot in Emperor (I checked and this error is reproducible with normal scatterplots or biplots)
Screen Shot 2020-01-07 at 11 16 30 PM
  1. Go to the Axes tab and set all axes to the same PC (I know, I know). As expected, all of the samples are constrained to a single line in the ordination space.
Screen Shot 2020-01-07 at 11 18 05 PM
  1. Set any of the axes to a different PC. Now, for some reason, the axis display is duplicated:
Screen Shot 2020-01-07 at 11 20 16 PM

Note that the "direction" of the duplication (wherever the new axis display ends up in relation to the original one) seems to be based on the axis you changed in step 3 -- changing the first axis as shown in the screenshot shifts the duplicate axis horizontally, changing the second axis shifts the duplicate axis vertically (see below), and changing the third axis shifts the duplicate axis "towards the camera" (at least from the default camera settings).

Screen Shot 2020-01-07 at 11 22 50 PM

I don't know why this error happens, but it might have ramifications for other parts of Emperor.

ElDeveloper commented 4 years ago

Thanks for reporting @fedarko!

@dhakim87, do you think this could have anything to do with how the axes drawing was reworked in your previous PR? Any chance you can have a look at this?