search

biocore / emperor

Emperor a tool for the analysis and visualization of large microbial ecology datasets
http://biocore.github.io/emperor/
Other
52 stars 50 forks source link

BLD: Drop support for Python 2.7 #752

Closed ElDeveloper closed 4 years ago

ElDeveloper commented 4 years ago

:snake: 🔥

We need to continue to use gjslint which only runs in 2.7.x (hence the invocation in .travis.yml) but otherwise we should be good.

ElDeveloper commented 4 years ago

tl;dr Python and JavaScript unit tests failures were not being reported in travis. I've fixed this in this PR, @antgonza and @dhakim87 can you both have a look?

The problem was that we were running the tests like:

coverage run tests/all_tests.py ; coverage report

Which meant that regardless of the output from the unit tests, the command coverage report would always succeed, thus shadowing the real output of the previous command. I changed this to:

coverage run tests/all_tests.py && coverage report

So now travis will be able to report if tests fail since the first command needs to succeed before the second command is executed.

ElDeveloper commented 4 years ago

Thanks for the reviews @thermokarst and @antgonza!

ElDeveloper commented 4 years ago

Thanks so much both!