Fix color sorting in the legend

biocore / emperor

Emperor a tool for the analysis and visualization of large microbial ecology datasets

http://biocore.github.io/emperor/

Other

52 stars 50 forks source link

Fix color sorting in the legend #765

Closed fedarko closed 4 years ago

fedarko commented 4 years ago

Closes #761; see https://github.com/biocore/emperor/issues/761#issuecomment-629555803 for details on the way I fixed the bug.

Along with the fix to DecompositionView.setCategory(), I also added in a test to make sure that these changes remain in effect. Also made some minor code fixes in test_decomposition_view.js.

Hope this is useful!

fedarko commented 4 years ago

@ElDeveloper done, thanks!

fedarko commented 4 years ago

For some reason, it looks like the gjslint / flake8 versions used on Travis changed between last week and this week -- hence why the build was failing. Things should be fixed now (most of the complaints were minor things like double vs. single quotes).