BUG: Remove rawgit and a bit of jQuery

biocore / emperor

Emperor a tool for the analysis and visualization of large microbial ecology datasets

http://biocore.github.io/emperor/

Other

52 stars 50 forks source link

BUG: Remove rawgit and a bit of jQuery #808

Closed ElDeveloper closed 2 years ago

ElDeveloper commented 2 years ago

We use jsdelivr instead of rawgit which has better support for versioning, etc.
The style template needed jQuery but some distributions, such as Voilá, would not make jQuery available making this template crash.

Fixes #751

antgonza commented 2 years ago

Thank you for submitting these changes, they look fine - just to confirm, is it OK to merge?

ElDeveloper commented 2 years ago

Should be good to go, same as the other open PR 👍

Yoshiki Vázquez-Baeza

On Jan 31, 2022, at 6:04 AM, Antonio Gonzalez @.***> wrote:

Thank you for submitting these changes, they look fine - just to confirm, is it OK to merge?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

ElDeveloper commented 2 years ago

Thanks @antgonza!

Yoshiki Vázquez-Baeza

On Jan 31, 2022, at 8:37 AM, Antonio Gonzalez @.***> wrote:

Merged #808 into master.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.