biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
48 stars 31 forks source link

Rerun GitHub Actions on push events to master; update dev documentation to mention a weird thing with JS tests #468

Closed fedarko closed 3 years ago

fedarko commented 3 years ago

Should fix #467 (I think ... I don't really have a way of testing this).

Also updates CONTRIBUTING.md based on discussion with @gibsramen (we figured out the reason #464 was failing, and the errors being emitted from that reason were pretty obscure -- hopefully this helps clarify things for future devs).

kwcantrell commented 3 years ago

I did not include the push event because github actions in order to save computation time on the github servers. But it makes sense that it is needed in order to update the status badge. Plus, it will also rerun the on the merged code and check for any weird errors that might pop up.

kwcantrell commented 3 years ago

Thanks @fedarko!