biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
48 stars 31 forks source link

make _to_dict() public #472

Closed kwcantrell closed 3 years ago

kwcantrell commented 3 years ago

In response to #470.

Rather than adding a parameter to return a copied version of the empress dictionary object, I decided to provided a warning in the doc string stating that to_dict returns references to internal objects. As @gwarmstrong mentioned in #470, its seems kind of wasteful to copy the object and since python does not technically have private variables I decided to simply return the dictionary object as is.