search

biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
48 stars 31 forks source link

Write out README image links explicitly #477

Closed fedarko closed 3 years ago

fedarko commented 3 years ago

Some of the images in the README are referred to with their full URL, as follows:

image

And some of the images in the README are referred to with partial URLs:

image

Both of these work ok for the README on GitHub (GitHub can interpret partial URLs like the second example here), but the PyPI version of the README can't interpret these "partial" URLs. So this results in some broken images:

image

To fix this, we'd just need to adjust all image links in the README to use the full URL (as in the first example above).

Thanks @ElDeveloper for bringing this up.

96RadhikaJadhav commented 3 years ago

@fedarko Can I work on the issue?

ElDeveloper commented 3 years ago

Thanks @96RadhikaJadhav, I've assigned you to this issue.

fedarko commented 3 years ago

Addressed in #478.