search

biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
48 stars 31 forks source link

New color map #483

Closed kwcantrell closed 3 years ago

kwcantrell commented 3 years ago

This PR adds a new custom diverging color map (green to light orange to purple) that is great for coloring tree branches as a lot of the other diverging color maps are either hard to see the separation of values and/or the middle values are colored to light which makes the branches hard to see. log_ratio You can see that this color map does a good job separating the two extreme values (i.e. endpoints) from the middle values while still making everything visible on screen.

kwcantrell commented 3 years ago

@fedarko thanks for reviewing this! I think I have addressed all of your comments.

kwcantrell commented 3 years ago

Sorry to nitpick but I have one more suggestion (I don't think it's needed but it will probably cause confusion if left unfixed). Aside from that, this looks good!

Nitpick away :)

It should be fixed now.

fedarko commented 3 years ago

Perfect, thanks so much!