search

biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
45 stars 31 forks source link

Dynamic bp tree #490

Closed kwcantrell closed 3 years ago

kwcantrell commented 3 years ago

This PR implements a shear method for the bp tree that is based on https://github.com/wasade/improved-octo-waddle/blob/master/bp/_bp.pyx#L732

@wasade if you can take a look at this that would be awesome!

wasade commented 3 years ago

This looks awesome!!! +1

ElDeveloper commented 3 years ago

Thanks so much @wasade. @kwcantrell, it looks like there's only a handful of comments from my review but otherwise this should be good to be merged.

ElDeveloper commented 3 years ago

Thanks @kwcantrell