biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
45 stars 31 forks source link

Fix bug with running standalone version; account for NumPy dependency in standalone install instructions; a few small changes w/r/t node circle options #495

Closed fedarko closed 3 years ago

fedarko commented 3 years ago

There's a line in _plot_utils.py that imports q2templates, a package which is (usually) only available in QIIME 2 conda environments. This was breaking the standalone script when ran outside of a QIIME 2 environment.

To fix this, we can just move the import down so that it's only done if EMPress is being run through QIIME 2. This fixes the problem.

A very warm thank you to @ammaraziz for pointing this out!

Edit - I also made a few changes in this PR's later commits that make the UI for changing the node circle behavior a bit nicer. Should be limited to just cosmetic changes to the HTML.

ElDeveloper commented 3 years ago

Thanks @fedarko !