biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
48 stars 31 forks source link

Small side panel formatting fix: hide button <p> containers instead of buttons; fix prev/next frame animation buttons #514

Closed fedarko closed 3 years ago

fedarko commented 3 years ago

This doesn't entirely fix the problems brought up in #513, but it is a start -- it removes some unnecessary whitespace in the sample/feature metadata coloring and animation panels.

Hiding the button(s) inside a <p> tag still leaves some extra whitespace, since empty <p> tags still take up some space. Hiding the <p> tag directly (instead of the button(s)) fixes this, so now for example the default state of the animation panel looks a bit nicer:

previous now
image image

This PR also adjusts the animation panel so that:

prev frame button disabled next frame button disabled
image image
emperor-helper commented 3 years ago

The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv, just-fm.qzv, plain.qzv

ElDeveloper commented 3 years ago

@fedarko can you pull from upstream to see the mchelper build?

ElDeveloper commented 3 years ago

I added/removed a suggestion so that triggered a new build.

ElDeveloper commented 3 years ago

Sounds fair. Thanks @fedarko !