search

biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
48 stars 31 forks source link

Improves error handling when "shear" but no metadata passed #525

Closed ChrisKeefe closed 3 years ago

ChrisKeefe commented 3 years ago

When tree_plot is run with shear-to-feature-metadata, but no metadata is passed, the following error is produced. image

This PR explicitly handles that case, improving the error message: image

ChrisKeefe commented 3 years ago

Fixed the linter error I introduced, but left the other two alone to keep the diff minimal. I can fix these other two here if you like. image

kwcantrell commented 3 years ago

Thanks @ChrisKeefe for catching/fixing the shear-to-feature-metadata bug as well as discovering/fixing the lint issue(s)! This a two-for-one PR! :100::1st_place_medal: :100:

Since you are a first time contributor, I will go ahead an approve the workflows so that our CI can run and after that I this should be good to merge into master.