search

biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
48 stars 31 forks source link

BUG: Draw node circles as needed in SVG export #527

Closed fedarko closed 3 years ago

fedarko commented 3 years ago

Noticed that node circles were being left out of the SVG tree export, even when node circles are explicitly enabled for some or all nodes.

I believe this was happening because export-util.js hadn't been updated in light of #486's changes:

https://github.com/biocore/empress/blob/df3a4da5a5b23d465937112dfa2050f8957bb0ed/empress/support_files/js/export-util.js#L337

The Drawer.showTreeNodes flag was removed in #486, so I guess thanks to Javascript's magic if (drawer.showTreeNodes) will always silently evaluate to undefined (aka false) ._.

This PR fixes this problem. Fortunately, the way #486 is set up seemed to make it pretty easy to get this working again.

kwcantrell commented 3 years ago

Thanks for fix this @fedarko!