search

biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
45 stars 31 forks source link

sorted all menus #545

Open kwcantrell opened 3 years ago

kwcantrell commented 3 years ago

This sorts all drop down menus and the node select menu. This should hopefully make it much easier to find things :smile:

emperor-helper commented 3 years ago

The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv, just-fm.qzv, plain.qzv

kwcantrell commented 3 years ago

The main motivation behind sorting everything came up while demonstrating EMPress to the health team during Tuesdays meeting. They have a lot of metadata columns and the current method made it fairly difficult to find things. I think for more general uses, this will be the case. It maybe nice to list confidence after taxonomy but I think that small convenience is outweighed by the possible frustration of having to search for every other category. I could be wrong though :smile:

fedarko commented 3 years ago

Fair enough! Since there's a compelling reason for it, I don't mind this change.

I think that small convenience is outweighed by the possible frustration of having to search for every other category.

Agreed.

We miiiight be able to get the best of both worlds by renaming Confidence to Taxonomy Confidence or something, which would automatically mean that the column would be listed after the taxonomy levels (the Level 1 names, etc. are already made up by Empress, so this has precedent). But that fix will cause its own problems and is a discussion for another day :)

kwcantrell commented 3 years ago

Looks like McHelper is failing again... :cry:

kwcantrell commented 3 years ago

@fedarko I believe I addressed all your comments.

ElDeveloper commented 3 years ago

Did you try rerunning the jobs? I just restarted them. It’s likely an IP related problem(?). 🐧

Yoshiki Vázquez-Baeza

On Aug 26, 2021, at 12:51 PM, kwcantrell @.***> wrote:

 Looks like McHelper is failing again... 😢

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

ElDeveloper commented 3 years ago

Yep, artifacts should be updated now.

ElDeveloper commented 2 years ago

@fedarko any chance you can review and merge if things look good to you?

fedarko commented 2 years ago

@ElDeveloper yep, I will do my best to get to the remaining open pull requests ASAP.

ElDeveloper commented 2 years ago

Thanks so much!

Yoshiki Vázquez-Baeza

On Oct 26, 2021, at 12:48 PM, Marcus Fedarko @.***> wrote:

 @ElDeveloper yep, I will do my best to get to the remaining open pull requests ASAP.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.