search

biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
45 stars 31 forks source link

Allow settings import/export #551

Open jwdebelius opened 2 years ago

jwdebelius commented 2 years ago

Hi!

I really appreciate empress. I'm wondering if it would be possible to introduce one of my favorite features from emperor. I really liked the ability to export/import a settings file that would configure the display with the colors, annotations, rotation, and scale. It can take like 10-15 minutes to get things exactly the way I want as I annotate several layers of data. I'd love to see a similar thing in the future to support my erm... laziness?

fedarko commented 2 years ago

Thanks @jwdebelius -- I agree, this would be extremely useful to have in EMPress! We've had this on the docket for a while; I think we could maybe merge this with #131?

From what I remember, we were originally planning to focus on refactoring some of EMPress' code to make programmatically setting the application state easier, and then implement this sort of import/export functionality afterwards. At this point, though, it might make sense to go for the "quick-and-dirty" version of this sooner? Not sure what other folks' thoughts are on this. At least personally, I have much less time this year than last year to focus on EMPress' codebase (still have a few PRs I need to go review/merge...).

jwdebelius commented 2 years ago

I think it, sorry! 😳

And I totally understand how that happens! I hope things are going well. It's just a feature I'll anxiously await, when it gets here

gibsramen commented 2 years ago

At this point, though, it might make sense to go for the "quick-and-dirty" version of this sooner?

@fedarko I think this would be best. I can take a stab at a rudimentary version of this in the next couple of weeks but no promises.

fedarko commented 2 years ago

@jwdebelius No worries at all!!! It's always useful for us to know what planned features will be helpful for users to have; this is a reminder for me to get back to work ;)

@gibsramen that would be super dope, thanks! Hit me up if you want to try to pair-program this or something. We might be able to knock this out in a day or two (although I also have finals coming up soon so, uh, ditto on the no promises thing from my end)

ElDeveloper commented 2 years ago

Just my two cents, as much as possible mimicking the JSON format in EMPeror would be great. Thanks for working on this, it'll be super helpful to have this.

On Nov 25, 2021, at 10:33 11AM, Marcus Fedarko @.***> wrote:

@jwdebelius No worries at all!!! It's always useful for us to know what planned features will be helpful for users to have; this is a reminder for me to get back to work ;)

@gibsramen that would be super dope, thanks! Hit me up if you want to try to pair-program this or something. We might be able to knock this out in a day or two (although I also have finals coming up soon so, uh, ditto on the no promises thing from my end)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

justinshaffer commented 2 years ago

Thanks for the great tool! I wanted to express my enthusiasm for this functionality - looking forward to seeing it implemented.