biocore / empress

A fast and scalable phylogenetic tree viewer for microbiome data analysis
BSD 3-Clause "New" or "Revised" License
45 stars 31 forks source link

Race condition / itermittent failure in one of the barplot tests #557

Open fedarko opened 2 years ago

fedarko commented 2 years ago

Noticed while working on #521 -- this particular test was failing (it was expecting 216 coordinates, but only saw 72). Adding log statements during debugging seemed to cause the test to stop failing, and the test kept passing even after I removed the logs again?

Since I don't think #521 touches any of the code impacting this check, I suspected at first that it was a race condition, but now I'm not sure about that. In any case, we can always comment this test out if it becomes a problem, since it's not super important.