numerator cutoff is slightly off in proportion_plot

biocore / gneiss

compositional data analysis toolbox

https://biocore.github.io/gneiss/

BSD 3-Clause "New" or "Revised" License

55 stars 28 forks source link

numerator cutoff is slightly off in proportion_plot #275

Open mortonjt opened 5 years ago

mortonjt commented 5 years ago

From this forum post: https://forum.qiime2.org/t/gneiss-picking-up-of-meaningful-balances/8909/5

It looks like the numerator / denominator cutoff is slightly off -- here Bifidobacter should be in denominator - but in the plot, it looks like it is in the numerator.

justinshaffer commented 5 years ago

@mortonjt - Thanks! If this is directly related to the dark- vs. light-blue shading cutoff in the plot, it is a bit misleading and I think should be fixed. In the example provided, it looks like 11/20 taxa are binned into light-blue (numerator) whiel only 9/20 into dark-blue (denominator). Probably a [simple] fix with the cutoff for inclusion in either dark- vs. light-blue?

CC: @fedarko

fedarko commented 5 years ago

@mortonjt Justin and I think we may have narrowed the problem down to around this region of q2-gneiss' codebase. The comment about "overriding the default colors in the numerator / denominator" seems a bit suspicious.