search

biocore / gneiss

compositional data analysis toolbox
https://biocore.github.io/gneiss/
BSD 3-Clause "New" or "Revised" License
55 stars 28 forks source link

MAINT: update reindex_axis for pandas 0.25.1 #282

Closed ebolyen closed 5 years ago

ebolyen commented 5 years ago

Hey @mortonjt, we were updating QIIME 2's environment, and we saw gneiss was still using the older pandas API which has since been removed. Fortunately, it's a very simple fix.

(I also fixed the assertEquals deprecation warnings while I was at it).

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 96.703% when pulling d1196a71327282023623c5c53ee291bc2edce217 on ebolyen:pandas-0.25.1 into 20cbcaa6d889eea8462866d4b62e12509f84d47f on biocore:master.

ebolyen commented 5 years ago

Oh no. We've been here before: https://github.com/biocore/gneiss/pull/280

mortonjt commented 5 years ago

ouch - not sure how I missed that. These changes look good @ebolyen . Let me close #280. Thanks!

thermokarst commented 5 years ago

Thanks @mortonjt! Will you be able to cut a new conda package for this? We will need it for q2-gneiss, in order to keep it up-to-date in the next release of QIIME 2 (scheduled for the end of the month).

mortonjt commented 5 years ago

ok. A release has been cut and is now on pypi

Regarding conda - I've pushed a PR here to upgrade the version number.