search

biocore / labadmin

Administration website for the Knight Lab
4 stars 16 forks source link

Plate mapper kiwi checkpoint 02 #141

Closed qiyunzhu closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage increased (+7.3%) to 76.485% when pulling 5c9cca041febd6866d9d0ed9469782c668914837 on qiyunzhu:plate-mapper-kiwi-checkpoint into b5a4817664372afd026f683cf75318e91272a756 on biocore:plate-mapper-kiwi.

qiyunzhu commented 8 years ago

Hi all, thanks to Jose's kind instruction, I have successfully implemented Qiita's transaction module into labadmin. Now the transaction function works as expected. Therefore I rewrote the functions relevant to "study". Following Jose's suggestion, I simplified the Python code, moving repeated statements into separate functions. One of them looks awkward to me, though. Please let me know if you are all comfortable with the new version. Thank you! - Qiyun

coveralls commented 8 years ago

Coverage Status

Coverage increased (+6.02%) to 75.173% when pulling 9ddfe63f66766fb2af9f334dec4e1e74bc0ac6f1 on qiyunzhu:plate-mapper-kiwi-checkpoint into b5a4817664372afd026f683cf75318e91272a756 on biocore:plate-mapper-kiwi.

qiyunzhu commented 8 years ago

Dear all,

I appended functionalities regarding "samples" into this PR as well. Happy reviewing!

Note: for all "samples" functions, I have them to work on multiple samples all at once. My rationale is: it will be a very common situation that multiple samples are affected in one operation, and it is important to ensure the atomicity of this entire operation. For example, the user wants to create 96 samples. After 50 samples have already been created, the 51 one has an invalid sample ID, and the whole operation is aborted. Then we need to make sure the first 50 samples are cleared out.

Note: so far "studies" and "samples" are not linked up together. I will add these functionalities in the next PR.

Best, Qiyun

coveralls commented 8 years ago

Coverage Status

Coverage increased (+7.8%) to 76.964% when pulling 5e52f938997d743f7f54ee8cc19671c0a2b6c4be on qiyunzhu:plate-mapper-kiwi-checkpoint into b5a4817664372afd026f683cf75318e91272a756 on biocore:plate-mapper-kiwi.

josenavas commented 8 years ago

@qiyunzhu can you pull from upstream plate-mapper-kiwi and update this PR, thanks!

qiyunzhu commented 8 years ago

I fixed it. Now here is the new PR: https://github.com/biocore/labadmin/pull/142

On Thu, Sep 29, 2016 at 6:50 PM, Jose Navas notifications@github.com wrote:

@qiyunzhu https://github.com/qiyunzhu can you pull from upstream plate-mapper-kiwi and update this PR, thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/labadmin/pull/141#issuecomment-250639245, or mute the thread https://github.com/notifications/unsubscribe-auth/AEMVN43Oni82Nx61uMvzGr0ljeyfWTcKks5qvGr9gaJpZM4KJd-C .

josenavas commented 8 years ago

Thanks! For future reference, note that you don't need to close the PR, if you pull, fix the merge conflicts and push again the PR will update :-)

qiyunzhu commented 8 years ago

Sorry! That was because I wasn't sure how to resolve conflict properly. So I deleted the entire branch and created a new one :P

On Thu, Sep 29, 2016 at 8:58 PM, Jose Navas notifications@github.com wrote:

Thanks! For future reference, note that you don't need to close the PR, if you pull, fix the merge conflicts and push again the PR will update :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/labadmin/pull/141#issuecomment-250653082, or mute the thread https://github.com/notifications/unsubscribe-auth/AEMVNxNMLO2b9GvOKgANZhtwtGAXwbt5ks5qvIjkgaJpZM4KJd-C .