Closed sjanssen2 closed 7 years ago
coverage went down because of a new function for unit testing in data_access, which I cannot unit test itself
That's a cool idea @josenavas I have integrated it!
👍 @qiyunzhu can you do a quick review?
@qiyunzhu @mortonjt @wasade would be greate to get a review and merge within the next 15 minutes to be able to push the next fix
is it good to merge now @josenavas ?
I re-designed the assumptions made for running unit tests for external survey sources, i.e. I carefully ensured that necessary data are inserted and reverted for those tests that need it. I chose not to use setup() and teardown() because those tests are doing this at some points implicitly.
@josenavas @mortonjt @wasade please give this a quick review to avoid merge conflicts with other people how are working on those tests!