biocore / labadmin

Administration website for the Knight Lab
4 stars 16 forks source link

proper insertion and roll back for third party survey tests #172

Closed sjanssen2 closed 7 years ago

sjanssen2 commented 7 years ago

I re-designed the assumptions made for running unit tests for external survey sources, i.e. I carefully ensured that necessary data are inserted and reverted for those tests that need it. I chose not to use setup() and teardown() because those tests are doing this at some points implicitly.

@josenavas @mortonjt @wasade please give this a quick review to avoid merge conflicts with other people how are working on those tests!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.826% when pulling 06e4e6e84d7256a8a130a5f42792bc1f388b90e2 on sjanssen2:update_populatetestdb_v2 into 4d9ff567bd3aba8d9eae5dd476f6c3437b7c2d6b on biocore:master.

sjanssen2 commented 7 years ago

coverage went down because of a new function for unit testing in data_access, which I cannot unit test itself

sjanssen2 commented 7 years ago

That's a cool idea @josenavas I have integrated it!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.826% when pulling c94ecf3acdda88358456692f4c253239c5483163 on sjanssen2:update_populatetestdb_v2 into 4d9ff567bd3aba8d9eae5dd476f6c3437b7c2d6b on biocore:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.826% when pulling 2cc19ffc56a3c249f36655b784604460284ae3a7 on sjanssen2:update_populatetestdb_v2 into 4d9ff567bd3aba8d9eae5dd476f6c3437b7c2d6b on biocore:master.

josenavas commented 7 years ago

👍 @qiyunzhu can you do a quick review?

sjanssen2 commented 7 years ago

@qiyunzhu @mortonjt @wasade would be greate to get a review and merge within the next 15 minutes to be able to push the next fix

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.826% when pulling 006c1d009e8b4883668eebcaf777dd862fdfc275 on sjanssen2:update_populatetestdb_v2 into 4d9ff567bd3aba8d9eae5dd476f6c3437b7c2d6b on biocore:master.

sjanssen2 commented 7 years ago

is it good to merge now @josenavas ?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.826% when pulling 8ba4c9ac40f8daabe65de2d939a8a9543ca10810 on sjanssen2:update_populatetestdb_v2 into 4d9ff567bd3aba8d9eae5dd476f6c3437b7c2d6b on biocore:master.