search

biocore / labadmin

Administration website for the Knight Lab
4 stars 16 forks source link

fixing barcode_utils tests #178

Closed sjanssen2 closed 7 years ago

sjanssen2 commented 7 years ago

proper encoding of utf8 fields getting barcodes from DB which are unassigned or handed out

sjanssen2 commented 7 years ago

~WAIT, I tested against the wrong DB version. Thus, this is work in progres. Don't merge!~

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 91.678% when pulling 48e3d1130ffb4c5ed0566fdf516311badac91426 on sjanssen2:ut_test_barcode_util.py into 995e99492ede7a57fa1f37671b44739c33c1efb8 on biocore:master.

josenavas commented 7 years ago

@sjanssen2 If I understand correctly, this is the last PR needed to change all the tests to use the new scrubbed DB. Do you need any help trying to finish these ones?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.651% when pulling 1d4a74ff81e8ccd05b7ec8f57c49bb2723ad8949 on sjanssen2:ut_test_barcode_util.py into 98358e157ae710e1ac56146552cc1b4bf25131d5 on biocore:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.651% when pulling cbdaba92c4aac8fa8877f97d453fece44af10883 on sjanssen2:ut_test_barcode_util.py into 98358e157ae710e1ac56146552cc1b4bf25131d5 on biocore:master.

sjanssen2 commented 7 years ago

Ready for reviews @antgonza @josenavas @wasade

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.651% when pulling 58444421d82f3f81ad477dca84f618d97a037990 on sjanssen2:ut_test_barcode_util.py into 98358e157ae710e1ac56146552cc1b4bf25131d5 on biocore:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.651% when pulling a0146db14b2d5b3bafdaa082b72236b7c05f7b54 on sjanssen2:ut_test_barcode_util.py into 98358e157ae710e1ac56146552cc1b4bf25131d5 on biocore:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.651% when pulling c9547943c12dbebf36bd232f3d94fb1c91c39584 on sjanssen2:ut_test_barcode_util.py into 98358e157ae710e1ac56146552cc1b4bf25131d5 on biocore:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.651% when pulling e960aaeadfa079bd7543ef96df3dae66d7bd2a7b on sjanssen2:ut_test_barcode_util.py into 98358e157ae710e1ac56146552cc1b4bf25131d5 on biocore:master.

josenavas commented 7 years ago

@wasade can you check if your comments have been addressed?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.07%) to 91.651% when pulling 0da9d7d0f23ca1ca7f55d66922d286b00c45e1d0 on sjanssen2:ut_test_barcode_util.py into 98358e157ae710e1ac56146552cc1b4bf25131d5 on biocore:master.

josenavas commented 7 years ago

Thanks @wasade and @sjanssen2 !! @wasade wanna merge?

josenavas commented 7 years ago

Merging since @wasade's comments have been addressed