search

biocore / labadmin

Administration website for the Knight Lab
4 stars 16 forks source link

TargetGene Library prep #201

Closed josenavas closed 7 years ago

josenavas commented 7 years ago

This PR depends on https://github.com/biocore/american-gut-web/pull/656, https://github.com/biocore/labadmin/pull/200, so review/merge those ones first

This adds the bits for choosing the Target Gene library prep parameters

Gif (error page due to missing page - next PR): 16slibraryprep

josenavas commented 7 years ago

@antgonza @wasade @qiyunzhu this is ready for review - thanks!

josenavas commented 7 years ago

@qiyunzhu given your comments I don't think you've seen all the changes present in this PR (sometimes happens with GitHub, that is only showing the changes from the last commit, rather than all of them). There are ~800 lines of code modified here :)

qiyunzhu commented 7 years ago

@josenavas Oh sorry! Now I see all of them. Let me read!

wasade commented 7 years ago

I'm +1

josenavas commented 7 years ago

Tests are failing due to https://github.com/biocore/american-gut-web/pull/657 can that PR be reviewd/merged?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 92.009% when pulling e3ac9d673a4e694bd4f1da5ec953aaca9b84f11d on josenavas:library-prep into 3dcddecf2ad575b1ce63873536a29d759cb30b50 on biocore:plate-mapper-kiwi.

josenavas commented 7 years ago

:boom:

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 92.009% when pulling 88169b96d335f3efe1489e4e019365e808dd3fa7 on josenavas:library-prep into 3dcddecf2ad575b1ce63873536a29d759cb30b50 on biocore:plate-mapper-kiwi.

ElDeveloper commented 7 years ago

Thanks @josenavas