search

biocore / labadmin

Administration website for the Knight Lab
4 stars 16 forks source link

Shotgun normalization for library prep #220

Closed josenavas closed 7 years ago

josenavas commented 7 years ago

This adds the GUI to get the Qubit assays from a plate and generate the echo pick list normalization file

josenavas commented 7 years ago

Hey, the error here is because it is saying that "knimin/lib/data_access.py:4698:5: C901 'KniminAccess.quantify_shotgun_plate' is too complex (16)"

do we really need to block the PR for that?

wasade commented 7 years ago

It can be ignored on a per-method basis as well with # noqa: C901 i think

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.6%) to 91.973% when pulling 4c0918b90cdcc7da8592e2724b4f0dbd02f1d950 on josenavas:pm-gui-echo-norm into 5e0527618971d1a0323aeb2dc580c3ad015679f9 on biocore:plate-mapper-kiwi.

josenavas commented 7 years ago

@wasade @ElDeveloper @qiyunzhu are either of you available for a review here?

qiyunzhu commented 7 years ago

@josenavas Thanks! Looks good now.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 92.242% when pulling 05aa81903c91f4f5d9ce3055ac6ac60a2e1b79e9 on josenavas:pm-gui-echo-norm into f82e0d8ae5b142979c76518d2b957120e0bfb78f on biocore:plate-mapper-kiwi.

josenavas commented 7 years ago

Can this be merged?