search

biocore / labadmin

Administration website for the Knight Lab
4 stars 16 forks source link

Echo shotgun pool #232

Closed josenavas closed 7 years ago

josenavas commented 7 years ago

Generates the echo pick list for pooling

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 92.337% when pulling 22768a4bcccdeae8aaedde8178092e1a36b063b3 on josenavas:echo-shotgun-pool into 41fd7bbaddf62d68ade6f9471c131c00837e7edc on biocore:plate-mapper-kiwi.

josenavas commented 7 years ago

Thanks! Commits are gone - I was missing sync-ing with upstream

qiyunzhu commented 7 years ago

Looks good now!

ElDeveloper commented 7 years ago

Looks good to me, but tests are failing.

josenavas commented 7 years ago

Thanks for the heads up @ElDeveloper The failing test is a stochastic test that occurs sometimes when connecting to the google API, unrelated to the changes here

ElDeveloper commented 7 years ago

Fair enough, since this is only a google api-related failure I am merging this, thanks!