search

biocore / mds-approximations

Multidimensional scaling algorithms for microbiology-ecology datasets.
6 stars 7 forks source link

Fix eigenvector dimensionality reduction #25

Closed HannesHolste closed 8 years ago

HannesHolste commented 8 years ago

Patching previous PR #24 .

I fixed two mistakes that empirical testing revealed:

  1. Forgot to convert to numpy array
  2. Incorrectly sliced unwanted dimensions off array of eigenvectors
antgonza commented 8 years ago

I think these changes could have been push to the previous PR, right? But perhaps I'm missing something. Anyway, could you close this PR and commit these changes to the previous one?

HannesHolste commented 8 years ago

Unfortunately I already closed and merged the previous PR, so there's no way to merge this commit into the previous PR without rebasing the master branch history (which I could do only if nobody else has a copy of this codebase on their computer, because it'll mess up their history).

antgonza commented 8 years ago

But these changes are also included (or could be included) here: https://github.com/biocore/mds-approximations/pull/26, right?

HannesHolste commented 8 years ago

Ah, right. That works.