search

biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Removed confusing code + comment #101

Closed charles-cowart closed 1 year ago

charles-cowart commented 1 year ago

Removed confusing code + comment Removed temporary column 'plate_number' from final output.

Open PR of the above changes + anything forthcoming from MacKenzie or myself. @antgonza included as a reviewer since he is the main PoC, but his review shouldn't be necessary.

charles-cowart commented 1 year ago

@mmbryant23 @antgonza There is additional code here so Antonio should review this as well, IMHO. This should address all of our concerns from the original email including: In the notebook, plate number comes sample_plate and not Project Plate. Additional columns no longer appear in mapping file output. The duplicate 'Project_Name' column is removed and the 'project_name' column is renamed to 'Project_Name' in the mapping file.

I only have one question - is 'sample sheet Sample_ID’ a valid column for pre-prep file output? Currently it is still generated.

mmbryant23 commented 1 year ago

Left comments - Let me know if the proposed idea(s) make sense. Happy to get on a call today to discuss & resolve these asap. Thanks!!

On Thu, Mar 16, 2023 at 9:39 PM Charles Cowart @.***> wrote:

@mmbryant23 https://github.com/mmbryant23 @antgonza https://github.com/antgonza There is additional code here so Antonio should review this as well, IMHO. This should address all of our concerns from the original email including: In the notebook, plate number comes sample_plate and not Project Plate. Additional columns no longer appear in mapping file output. The duplicate 'Project_Name' column is removed and the 'project_name' column is renamed to 'Project_Name' in the mapping file.

I only have one question - is 'sample sheet Sample_ID’ a valid column for pre-prep file output? Currently it is still generated.

— Reply to this email directly, view it on GitHub https://github.com/biocore/metagenomics_pooling_notebook/pull/101#issuecomment-1472985323, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVY3ITUMVQKGU4HUZ5FA4HLW4O6DNANCNFSM6AAAAAAV4JHNVE . You are receiving this because you were mentioned.Message ID: @.***>

charles-cowart commented 1 year ago

@mmbryant23 Ready for review! If you'd like, we can jump on a call and preview the new notebook changes on my laptop and/or install metapool on your laptop before asking Jeff to update the server.

charles-cowart commented 1 year ago

Removing WIP as we're ostensibly done.