search

biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Update metadata_samples_plasmid_sequences.txt #109

Closed justinshaffer closed 11 months ago

justinshaffer commented 1 year ago

Added column for sample input weights and updated pool variable name

charles-cowart commented 11 months ago

@antgonza This looks like it goes hand in hand with https://github.com/biocore/metagenomics_pooling_notebook/pull/107

antgonza commented 11 months ago

... interestingly the tests (are there any tests?) didn't fail even if the changes are in different PRs.

charles-cowart commented 11 months ago

... interestingly the tests (are there any tests?) didn't fail even if the changes are in different PRs.

Yeah I'm not sure there's any tests for calculate_coefficients.py. I don't think I've ever touched or debugged any code in that file ever. I'll do some investigating.

charles-cowart commented 11 months ago

... interestingly the tests (are there any tests?) didn't fail even if the changes are in different PRs.

Yeah I'm not sure there's any tests for calculate_coefficients.py. I don't think I've ever touched or debugged any code in that file ever. I'll do some investigating.

Actually that file does not exist in the main metapool repo. I think we will need to work with Justin to get, review, pull in, and add tests for this new code before accepting this PR. I think we can close this one as it is.